Skip to content

🐛 Minor fixes for the function api #8376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 17, 2025
Merged

🐛 Minor fixes for the function api #8376

merged 14 commits into from
Sep 17, 2025

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Sep 17, 2025 •
edited
Loading

What do these changes do?

  • Improves and aligns conversion of celery task statuses to function job statuses.
  • Handles exception when celery task is missing.
  • Makes celery tasks non-ephemeral when running function.

Related issue/s

  • This PR is motivated by in-office discussions with @wvangeit

How to test

Dev-ops

@codecov
Copy link

codecov bot commented Sep 17, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.94%. Comparing base (7615106) to head (f7e30dd).
⚠️ Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (7615106) and HEAD (f7e30dd). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (7615106) HEAD (f7e30dd)
unittests 31 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #8376       +/-   ##
===========================================
- Coverage   87.82%   68.94%   -18.88%     
===========================================
  Files        1931      883     -1048     
  Lines       75393    39589    -35804     
  Branches     1337      175     -1162     
===========================================
- Hits        66212    27295    -38917     
- Misses       8782    12237     +3455     
+ Partials      399       57      -342
Flag Coverage Δ
integrationtests 63.94% <ø> (-0.01%) ⬇️
unittests 91.96% <100.00%> (+5.47%) ⬆️
Components Coverage Δ
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.75% <ø> (-8.19%) ⬇️
agent ∅ <ø> (∅)
api_server 91.96% <100.00%> (+0.03%) ⬆️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 78.03% <ø> (-12.92%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 81.87% <ø> (-8.59%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.80% <ø> (-29.16%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7615106...f7e30dd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis self-assigned this Sep 17, 2025
@bisgaard-itis bisgaard-itis added this to the Cheops milestone Sep 17, 2025
@bisgaard-itis bisgaard-itis marked this pull request as ready for review September 17, 2025 09:38
pcrespov
pcrespov approved these changes Sep 17, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 17, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented Sep 17, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for f7e30dd.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on master Retries 🔍 CI Insights 📄 Logs
CI unit-tests Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

GitHK
GitHK approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@bisgaard-itis bisgaard-itis merged commit 18249a4 into ITISFoundation:master Sep 17, 2025
91 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the further-fixes-for-function-api branch September 17, 2025 10:22
@bisgaard-itis bisgaard-itis mentioned this pull request Sep 18, 2025
Closed
This was referenced Sep 18, 2025
Closed
Closed
@mrnicegyu11 mrnicegyu11 mentioned this pull request Sep 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@wvangeit wvangeit Awaiting requested review from wvangeit wvangeit is a code owner

@sanderegg sanderegg Awaiting requested review from sanderegg

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@bisgaard-itis bisgaard-itis

Labels

a:apiserver api-server service Meta-modeling

Projects

None yet

Milestone

Cheops

Development

Successfully merging this pull request may close these issues.

3 participants

@bisgaard-itis @GitHK @pcrespov